[Dev] dbscripts 20180610 release announcment / winston.parabola.nu upgrade

[Luke Shumaker]

I've rolled out version 20180610 of Parabola dbscripts.

With the dbscripts updates last month, we had about a week and a half
of breakage with db-import.  I've gone through the logs, emails, and
bug tracker discussions, and have identified 11 separate bugs that we
encountered during that time.  I then wrote tests, and verified that
they caught those 11 bugs.  So this release, and all future releases,
should have a higher expectation of stability.  Yay.

However, adding tests hardly demands a new release, we have some real
changes too.

Changes from 20180507.1 to 20180610:
 - config:
   * rename PKGEXT to PKGEXTS, to avoid confusion with
     makepkg.conf:PKGEXT
   * change the default TMPDIR back to /tmp, from /srv/repo/tmp (see
     the change in db-import-pkg below)
 - db-import-pkg:
   * remove the requirement that config:TMPDIR be on the same
     filesystem as config:FTP_BASE
   * more code cleanup
 - minor global code cleanups from Arch.

On winston.parabola.nu, I have
 - run: sudo pacman -Syu --ignore=linux-libre-lts

-- 
Happy hacking,
~ Luke Shumaker

-------------- next part --------------
* Issues
** dbscripts
Bugs a-e were pre-existing subtle bugs.  Which makes sense; they were
unnoticed.  Bugs f-j were show-stopper bugs.  Which makes sense; they
were fixed quickly.  I actually didn't notice k until 2018-06-01; I
just accidentally fixed it.
| <l>         | a | b | c | d | e | f | g | h | i | j | k |
|-------------+---+---+---+---+---+---+---+---+---+---+---|
| preexisting | X | X | X | X | X |   |   |   |   |   |   |
| 20180425    | X | X | X | X | X | A |   |   |   |   |   |
| 20180429    | X | X | X | X | X | X |   |   |   |   |   |
| 20180429.1  | X | V | X | X | X | X |   |   |   |   |   |
| 20180501    | X |   | X | X | X | V |   |   |   |   |   |
| 20180502    | X |   | X | X | X |   | A |   |   |   | A |
| 20180502.1  | X |   | X | X | X |   | V | A |   |   | X |
| 20180502.2  | V |   | X | X | X |   |   | V |   |   | X |
| 20180505    |   |   | X | X | X |   |   |   | A | A | V |
| 20180507    |   |   | V | X | V |   |   |   | V | V |   |
| 20180507.1  |   |   |   | V |   |   |   |   |   |   |   |
|-------------+---+---+---+---+---+---+---+---+---+---+---|
| test        | Y | Y | Y | Y | Y | Y | Y | Y | Y | Y | Y |
*** (a) .db file mode is wrong
:PROPERTIES:
:CommitIntroduced: preexisting
:ReleaseIntroduced: preexisting
:CommitFixed: 1a3f6289ccfbb15cd8e8c3d28a8ee198fa477a30
:ReleaseFixed: 20180502.2
:END:
*** (b) /tmp access isn't safe
:PROPERTIES:
:CommitIntroduced: preexisting
:ReleaseIntroduced: preexisting
:CommitFixed: b6138f468bb77dfaa56c9927ea9298023a368785
:ReleaseFixed: 20180429.1
:END:
*** (c) TMPDIR is ignored by mktemp
:PROPERTIES:
:CommitIntroduced: preexisting
:ReleaseIntroduced: preexisting
:CommitFixed: 50f0090dd48b862faa892fd14afd3ecca12710cf
:ReleaseFixed: 20180507
:END:
*** (d) pkgpool selection is buggy
:PROPERTIES:
:CommitIntroduced: preexisting
:ReleaseIntroduced: preexisting
:CommitFixed: a9f1927584a312900e7db29cee7daa548301ec9f
:ReleaseFixed: 20180507.1
:END:      
https://labs.parabola.nu/issues/1791 (attn "extra/asp")
*** (e) pkgpool selection errors are ignored
:PROPERTIES:
:CommitIntroduced: preexisting
:ReleaseIntroduced: preexisting
:CommitFixed: fef7b4f6e946d50fcc37a5b8a795ba1ee6a2cfc6
:ReleaseFixed: 20180507
:END:      
*** (f) packages are removed instead of upgraded
:PROPERTIES:
:CommitIntroduced: 032b6810d1f323772d8ba078d0717bfcfa0f8911
:ReleaseIntroduced: 20180425
:CommitFixed: feecedde9164cbc40004fef18deca6ad598ecec5
:ReleaseFixed: 20180501
:END:
https://labs.parabola.nu/issues/1770

    > Changes from 20180429.1 to 20180501:
    >
    >  - db-import-pkg: Fix a variable mis-reference (pkgpool->ARCHPKGPOOL)
    >    that was introduced in v20180425.  This had the result that when
    >    Arch Linux released a new version of a package, rather than being
    >    updated in our repos, it was removed.  This did not affect
    >    importing packages from ALARM or Arch Linux 32.
*** (g) ARCHPKGPOOL URL has "}" in it
:PROPERTIES:
:CommitIntroduced: 42229d2ac2b3267a4435f69eeefeabaf4461ae4d
:ReleaseIntroduced: 20180502
:CommitFixed: 67581008b9e2c32cfead4377f965fdc884c1f41d
:ReleaseFixed: 20180502.1
:END:
*** (h) set_repo_permission crashes
:PROPERTIES:
:CommitIntroduced: 90ce65c0d0c0315a3213762cee052108fbee937d
:ReleaseIntroduced: 20180502.1
:CommitFixed: 1a3f6289ccfbb15cd8e8c3d28a8ee198fa477a30
:ReleaseFixed: 20180502.2
:END:
See also: e46378dc0dbe9ece0149e16752d9a2e93539085d
*** (i) default ARCHMIRROR wrong for archlinux{arm,32}
:PROPERTIES:
:CommitIntroduced: 324817e7d15104d708020e57d3f6e3c12fcf7351
:ReleaseIntroduced: 20180505
:CommitFixed: 8cc361c4befd54edeb4e1872972cc52434916f9c
:ReleaseFixed: 20180507
:END:
*** (j) tries to repo-add broken symlinks
:PROPERTIES:
:CommitIntroduced: 8393137cd49de14f0f74caee8e93fa43ca881e2b
:ReleaseIntroduced: 20180505
:CommitFixed: 50c33f2fd83ace66a1e0aa8e4e3a6acb8b6d0585
:ReleaseFixed: 20180507
:END:
See also: 0bb39453f523176c73fef0c693421dd2f46ecc05
*** (k) can't import repos with no blacklisted packages
:PROPERTIES:
:CommitIntroduced: cc59d2b3e02572607f486989aaef89e466cb7547
:ReleaseIntroduced: 20180502
:CommitFixed: bca226abf913df7269e861283e2de592786a1132
:ReleaseFixed: 20180505
:END:
NB: With pacman 5.0, this wasn't introduced until 20180502, but when
run with pacman 5.1, all versions prior to 20180505 exhibit this
problem.
** libreblacklist
*** (l) `blacklist-update` isn't concurrency-safe
:PROPERTIES:
:CommitIntroduced: fc9e5c56403fc53e373f7c9bc8cc448d1c00af21
:ReleaseIntroduced: 20130522
:CommitFixed: 9da24149f1e9197ff1961e5ae1966a675bf82d39
:ReleaseFixed: 20180428
:END:
https://labs.parabola.nu/issues/1768