[Dev] Orphan Pcr package [castle-combat] marked out-of-date

[Andreas Grapentin]

I gave this package a quick shot as well, and I can get it to start.
Unfortunately, the code quality is not very good, and, as theova said,
it would take a bit of an effort to clean up and get it up to good
working condition.

If this is desirable, then we should open an issue on the tracker
regarding this package to keep track of what needs to be done.

off the top of my head:
 - the setup.py file is broken, needs to be ported to to setuptools from
   distutils
 - the imports are relative and do not work if packgaged
 - there is no proper entry point, only a quick-and-dirty bash script.
   instead, the entry_points option of setuptools should be used
 - the package data is installed in /usr/bin/$pkgname, should rather be
   moved to /usr/share/$pkgname (the path is hardcoded)
 - the license of the sound and music assets is not clear
 - the code quality is not very good, imports are scattered all over the
   place, there is no clear structure

probably more to do here. This is not a job for distro maintainers, this
is a job for volunteers to the original project.

I'd be pretty sad to see it go, looks like a cool little project. I'd be
happy if there would be someone stepping up to get it back in shape. We
can also contact the original author of the package to get him in the
loop. At the very least, we should flood his github issue tracker :)

-A

On Fri, Apr 17, 2020 at 11:22:12AM +0200, theova wrote:
> Hi Viktor
> 
> I tried to update the PKGBUILD  for castle-combat. It is attached.
> You can build the package with makepkg -si, install it and play.
> 
> When I tried to play the game, it crashed always (I have done some
> research).
> 
> No my question: Would you like to keep the game in the PCR? This would
> need some activity like testing and issue reporting back to the
> castle-combat project.
> 
> If the game cannot run correctly, I see no sense in keeping it in
> Parabola's repositories...
> 
> Please ask if you have any questions.
> 
> Regards,
> Theova
> 
> Parabola Website Notification <nobody at parabola.nu> schrieb am Mon, 06.
> Jan 20 15:33:
> > viktor at viktorlindberg.com wants to notify you that the following packages may be out-of-date:
> > 
> > 
> > * castle-combat 0.8.1-3 [pcr] (armv7h): https://parabolagnulinux.org/packages/pcr/armv7h/castle-combat/
> > * castle-combat 0.8.1-3 [pcr] (i686): https://parabolagnulinux.org/packages/pcr/i686/castle-combat/
> > * castle-combat 0.8.1-3 [pcr] (x86_64): https://parabolagnulinux.org/packages/pcr/x86_64/castle-combat/
> > 
> > 
> > The user provided the following additional text:
> > 
> > 0.9.0 "Bring CC into the Present!" Has been released, now it should work.
> > 
> > _______________________________________________
> > Dev mailing list
> > Dev at lists.parabola.nu
> > https://lists.parabola.nu/mailman/listinfo/dev

> # Maintainer: Luke R. <g4jc at openmailbox.org> GPG: rsa4096/3EAE8697
> 
> pkgname=castle-combat
> pkgver=0.9.0
> pkgrel=1
> pkgdesc="Clone of the old arcade game Rampart. Build castle walls, place cannons inside these walls, and shoot at the walls the enemy(s)."
> arch=('any')
> url="http://www.linux-games.com/castle-combat/"
> license=('GPL2')
> depends=('ttf-dejavu' 'python-twisted' 'python-pygame' 'python-numpy')
> source=("https://github.com/karlb/$pkgname/archive/$pkgver.tar.gz")
> md5sums=('5bd4464107e47c2bd48e9a96889dccf0')
> 
> prepare() {
>     ## remove non-free font and macosx items
>     sed -i '/font = pygame.font/d' $srcdir/$pkgname-$pkgver/src/common.py
>     sed -i '/small_font = pygame.font.Font/d' $srcdir/$pkgname-$pkgver/src/common.py
>     sed -i '/global font/a font = pygame.font.SysFont("dejavusans", 34)' $srcdir/$pkgname-$pkgver/src/common.py
>     sed -i 's|font = pygame.font.SysFont|    font = pygame.font.SysFont|' $srcdir/$pkgname-$pkgver/src/common.py
>     sed -i '/global small_font/a small_font = pygame.font.SysFont("dejavusans", 24)' $srcdir/$pkgname-$pkgver/src/common.py
>     sed -i 's|small_font = pygame.font.SysFont|    \small_font = pygame.font.SysFont|' $srcdir/$pkgname-$pkgver/src/common.py
>     rm -rf $srcdir/$pkgname-$pkgver/dist $srcdir/$pkgname-$pkgver/src/colourba.ttf $srcdir/$pkgname-$pkgver/src/font_read_me.html
> }
> 
> package() {
>   mkdir -p $pkgdir/usr/bin/
>   cp -r $srcdir/$pkgname-$pkgver/ $pkgdir/usr/bin/
> cat <<EOF > $pkgdir/usr/bin/castle-combat
> #!/bin/bash
> cd /usr/bin/castle-combat-$pkgver
> python castle-combat.py
> EOF
> chmod 755 $pkgdir/usr/bin/castle-combat
> }




> _______________________________________________
> Dev mailing list
> Dev at lists.parabola.nu
> https://lists.parabola.nu/mailman/listinfo/dev


-- 

------------------------------------------------------------------------------
my GPG Public Key:                 https://files.grapentin.org/.gpg/public.key
------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.parabola.nu/pipermail/dev/attachments/20200417/f8763ff9/attachment.sig>