[Dev] [PATCH] Updates for ark, doublecmd, file-roller, khotkeys, kio, libksysguard, okular
grizzlyuser
grizzlyuser at protonmail.com
Fri Mar 27 17:34:37 GMT 2020
On Thursday, March 26, 2020 6:18 PM, Andreas Grapentin
<andreas at grapentin.org> wrote:
> 1.) Please name affected packages in the commit messages
>
> this makes it easier to see in the commit log what packages you mean
> when you say "updated to version foo.bar". Just write
> "libre/awesome: updated to version foo.bar" instead. This is a simple
> convention we are basically all following.
>
> I have taken the liberty of modifying your patches to include this
> change, I hope that's okay.
Thanks for the info, I'll take it into account for future
updates.
> 2.) Feel free to add yourself as a Contributor to the package
>
> If you make a significant change to a package, upwards of a trivial
> 'bump pkgver' diff, then this warrants your name to be added to the
> list of contributors. I would leave it to your judgement as to when
> and when not to do this, but I feel your level of contribution does
> deserve attribution.
>
> I have not changed this for the patches you sent in.
I'm not sure why the list of contributors is necessary, because
this info can be seen from git. Is this a project rule or some
other best practice? I can add it if needed, but will these
trivial changes require new pkgrel in PKGBUILD?
> More serious things:
>
> 3.) The doublecmd patch does not apply
>
> Please double check the version of libre.patch you have diffed
> against. The version in my copy of abslibre.git is subtly different,
> such that ALL hunks have failed. This patch is not trivial, and
> would be tough for me to get right, so I'm passing the ball back to
> you on this one :)
I've double checked, it builds successfully, whether it's been
applied using 'patch' or 'git apply'. Are you sure the patch has
not been modified after downloading? As I can see, CR/LF format
differs between files in Double Commander sources, and it took
some effort for me to regenerate the libre.patch so that it
applies without complains during prepare(). If the file like
this one has mixed format, some of the text editors will change
format on save, and the patch won't apply. Anyway, please find
updated patch attached, only commit message has been changed to
mention package name. Build passed for me with it.
> 4.) kio does not build for me on arm
>
> not quite sure about this, could be on my end, but kio complains about
> missing extra-cmake-modules during the prepare phase. Please
> double-check your build. are you building in a cross-arch chroot or on
> real hardware? Anything non-standard in your configuration?
I've recreated librechroot from scratch, it builds. I've seen
that error some time before when Arch Linux ARM repos had the
older version of extra-cmake-modules. Please check the chroot is
up to date.
Thank you for applying the changes and updating the packages!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libre-doublecmd-bump-to-0.9.8-1-update-patch.patch
Type: text/x-patch
Size: 19405 bytes
Desc: not available
URL: <https://lists.parabola.nu/pipermail/dev/attachments/20200327/83b97ed6/attachment-0001.bin>
More information about the Dev
mailing list