[Dev] [PATCH] Orphan Libre package [iceweasel] marked out-of-date

grizzlyuser grizzlyuser at protonmail.com
Thu Mar 26 09:58:39 GMT 2020


I'm sorry for the late reply, had completely abandoned the
mailbox for some time.

Please find the patch for Iceweasel 74.0-2 attached. As usual,
it contains descriptions of all the changes in commit messages.

Successfully built on x86_64, i686 and armv7h.


On Thursday, March 12, 2020 3:02 PM, Andreas Grapentin <andreas at grapentin.org> wrote:

> Thanks for the patches. I applied them and the packages are currently
> rebuilding. Keep them coming. Especially patches to update the ice*
> family of packages are always appreciated, mainly because they take so
> much time to get right.
>
> So thanks again!

Great! Thank you too!


On Friday, March 13, 2020 2:58 AM, bill-auger <bill-auger at peers.community> wrote:

> that is a bit confusing - there are several 'iceweasel' git repos; even one named 'iceweasel-branding.git'; which is actually not used anymore - we should probably delete that one and rename the current one to 'iceweasel-branding.git' - OTOH, i dont see why we could not fore-go making a special tarball each time, and simply add the git repo to the sources=() array
>
> anyways, the current one is at https://git.parabola.nu/packages/iceweasel.git/

Thanks you for all the suggestions!

This one is done in the commit 5. The only issue I see is that
sources tarball generated after libremakepkg appears to have
some git related files instead of the actual branding sources.
It looks like a bug in libremakepkg or whatever makes that
tarball. If something is not OK, please just disregard the
last commit.

> On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
>
> > --- a/libre/iceweasel/PKGBUILD
> > +++ b/libre/iceweasel/PKGBUILD
> > @@ -5,6 +5,7 @@
> >
> > Maintainer (alarm): Kevin Mihelich kevin at archlinuxarm.org
> >
> > ==========================================================
> >
> > Maintainer (arch32): Andreas Baumann mail at andreasbaumann.cc
> >
> > ============================================================
> >
> > Contributor (arch32): Erich Eckner git at eckner.net
> >
> > ==================================================
> >
> > +# Contributor (Arch Linux ARM): Kevin Mihelich kevin at archlinuxarm.org
>
> "Kevin Mihelich" is a duplicate there

Indeed, my bad, corrected.

> On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
>
> > -   .placeholder = Search addons.mozilla.org
> >
> > -   .placeholder = Search www.parabola.nu/packages
> >
> > +- .placeholder = Search addons.mozilla.org
> > ++ .placeholder = Search www.parabola.nu/packages
> > +
>
> nice little extra - we should go over BR #2488 to see how many nit-pickings still remain
> https://labs.parabola.nu/issues/2488
>
> im a bit confused about this though, now that im looking at it - in v72, the search queries are actually directed to the gnuzilla addons page
> https://directory.fsf.org/wiki/Gnuzilla
>
> (redirected apparently) - the query is dropped on the floor when it arrives; but i think the new null message will still be incorrect, until we sort out what is the purpose of each these keys - or maybe just delete that search box - or maybe convince gnuzilla to make it work as expected
>
> this is what i have in my v72 abslibre; and i dont see any changes in this latest patch-set:
>
> $ grep fsf vendor.js.in
> pref("extensions.webservice.discoverURL", "https://directory.fsf.org/wiki/GNU_IceCat");
> pref("extensions.getAddons.search.url", "https://directory.fsf.org/wiki/GNU_IceCat");
> pref("browser.search.searchEnginesURL", "https://directory.fsf.org/wiki/GNU_IceCat");
>
> $ grep 'www.parabola.nu/packages' vendor.js.in
> pref("extensions.getAddons.search.browseURL", "https://www.parabola.nu/packages/?q=%TERMS%");
>
> i think 'extensions.getAddons.search.url' is the one that controls that search box

It looks like latest upstream versions introduced changes that
remove older preferences. Please see [PATCH 3/5].

> On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
>
> > Let's stick as close to upstream as possible.
>
> that is the goal - this PKGBUILD has accumulated a lot of cruft over the years though - sometimes a switch or two need to be flipped just to get one arch to build - then they may be forgotten to be flipped back next time whenwhatever quirk has passed

Right. I think every flag and and preference may be removed or
change meaning in future, so it makes sense to review and update
them from time to time. But that's hard to go over each one of
them.

> On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
>
> > +# vim:set sw=2 et:
>
> yea maybe not that close though :)
> personally, i delete every one of those "litter-bug droppings" that i see and i am not ashamed to admit it

Sorry, I don't understand. Should it be deleted, or not?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: iceweasel_74.0-2.patch
Type: text/x-patch
Size: 16622 bytes
Desc: not available
URL: <https://lists.parabola.nu/pipermail/dev/attachments/20200326/a56a1461/attachment-0001.bin>


More information about the Dev mailing list