[Dev] Orphan Libre package [iceweasel] marked out-of-date

[bill-auger]

excellent job grizzlyuser - this is very thorough - thanks a lot

i made a few notes of some minor details i noticed


On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
> Please find updated patches for iceweasel 73.0-1 attached.
> Built and smoke tested for x86_64, armv7h, i686.
> 
> iceweasel_branding_73.0-1.patch should be applied to the
> contents of [1]. I couldn't find actual git repository for
> those. 

that is a bit confusing - there are several 'iceweasel' git repos; even one named 'iceweasel-branding.git'; which is actually not used anymore - we should probably delete that one and rename the current one to 'iceweasel-branding.git' - OTOH, i dont see why we could not fore-go making a special tarball each time, and simply add the git repo to the sources=() array

anyways, the current one is at https://git.parabola.nu/packages/iceweasel.git/


On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
> --- a/libre/iceweasel/PKGBUILD
> +++ b/libre/iceweasel/PKGBUILD
> @@ -5,6 +5,7 @@
>  # Maintainer (alarm): Kevin Mihelich <kevin at archlinuxarm.org>
>  # Maintainer (arch32): Andreas Baumann <mail at andreasbaumann.cc>
>  # Contributor (arch32): Erich Eckner <git at eckner.net>
> +# Contributor (Arch Linux ARM): Kevin Mihelich <kevin at archlinuxarm.org>

"Kevin Mihelich" is a duplicate there


On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
>  -    .placeholder = Search addons.mozilla.org
>  +    .placeholder = Search www.parabola.nu/packages
>
> +-    .placeholder = Search addons.mozilla.org
> ++    .placeholder = Search www.parabola.nu/packages
> +

nice little extra - we should go over BR #2488 to see how many nit-pickings still remain
https://labs.parabola.nu/issues/2488

im a bit confused about this though, now that im looking at it - in v72, the search queries are actually directed to the gnuzilla addons page
https://directory.fsf.org/wiki/Gnuzilla

(redirected apparently) - the query is dropped on the floor when it arrives; but i think the new null message will still be incorrect, until we sort out what is the purpose of each these keys - or maybe just delete that search box - or maybe convince gnuzilla to make it work as expected

this is what i have in my v72 abslibre; and i dont see any changes in this latest patch-set:

$ grep fsf vendor.js.in 
pref("extensions.webservice.discoverURL", "https://directory.fsf.org/wiki/GNU_IceCat");
pref("extensions.getAddons.search.url", "https://directory.fsf.org/wiki/GNU_IceCat");
pref("browser.search.searchEnginesURL", "https://directory.fsf.org/wiki/GNU_IceCat");

$ grep 'www.parabola.nu/packages' vendor.js.in 
pref("extensions.getAddons.search.browseURL", "https://www.parabola.nu/packages/?q=%TERMS%");

i think 'extensions.getAddons.search.url' is the one that controls that search box


On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
> Let's stick as close to upstream as possible.

that is the goal - this PKGBUILD has accumulated a lot of cruft over the years though - sometimes a switch or two need to be flipped just to get one arch to build - then they may be forgotten to be flipped back next time when _whatever_ quirk has passed


On Fri, 14 Feb 2020 21:52:25 +0000 grizzlyuser wrote:
> +# vim:set sw=2 et:

yea maybe not that close though :)
personally, i delete every one of those "litter-bug droppings" that i see and i am not ashamed to admit it