[Dev] [PATCH] Upgrade nextcloud-client to v3.0.0

[theova]

Hi,

Thanks for your answer. As this is interesting for other Devs, I reply
to the mailing list (please consider to subscribe to write to the
mailing list directly).

I've built it today with the newest packages in Parabolas repos and got
no such fail results.

However the second issue I can confirm on i3 (x11). If I start
nextcloud-client, the window appears under my mouse. As soon as I leave
the area, the window is away (without crashing). Under gnome, I cannot
reproduce this behaviour.

As the patches only address the login procedure, I do not think that
they are the reason for the "crash". It rather seems like a "bleeding
edge OS" issue which should be reported upstream to the nextcloud
developers.

eomc20a2q99n at opayq.com schrieb am Tue, 25. Aug 20 14:50:
>Hi, just tried your patch on x86_64. I'm having a couple weird errors. The first time I got this error during the build process:
>
>```
>94% tests passed, 2 tests failed out of 35
>
>Total Test time (real) = 120.80 sec
>
>The following tests FAILED:
>    14 - SyncMoveTest (Failed)
>    15 - SyncConflictTest (Failed)
>Errors while running CTest
>make: *** [Makefile:126: test] Error 8
>==> ERROR: A failure occurred in check().
>    Aborting...
>```
>I tried it again and the build worked, but I'm having a bunch of separate issues with the actual program.
>
>Under Wayland (Sway WM), if I open the GUI and focus my mouse anywhere on the screen, the GUI disappears (though it doesn't crash):
>
>```
>2020-08-25 13:42:22:651 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowReferencePoint ]:    screenRect: QRect(0,0 1920x1080)
>2020-08-25 13:42:22:651 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowReferencePoint ]:    taskbarRect: QRect(0,0 32x1080)
>2020-08-25 13:42:22:651 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowReferencePoint ]:    taskbarScreenEdge: OCC::Systray::TaskBarPosition::Left
>2020-08-25 13:42:22:651 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowReferencePoint ]:    trayIconCenter: QPoint(0,0)
>2020-08-25 13:42:22:651 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowPosition ]:    taskbarScreenEdge: OCC::Systray::TaskBarPosition::Left
>2020-08-25 13:42:22:652 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowPosition ]:    screenRect: QRect(0,0 1920x1080)
>2020-08-25 13:42:22:652 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowPosition ]:    windowRect (reference) QRect(36,0 1857x477)
>2020-08-25 13:42:22:652 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowPosition ]:    windowRect (adjusted ) QRect(36,0 1857x477)   Aborting...
>```
>
>If I set `QT_QPA_PLATFORM=xcb` (that is, force QT to use XWayland), the same thing happens:
>
>```
>2020-08-25 13:48:39:563 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowReferencePoint ]:    screenRect: QRect(0,0 1920x1080)
>2020-08-25 13:48:39:564 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowReferencePoint ]:    taskbarRect: QRect(0,0 1920x32)
>2020-08-25 13:48:39:564 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowReferencePoint ]:    taskbarScreenEdge: OCC::Systray::TaskBarPosition::Top
>2020-08-25 13:48:39:564 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowReferencePoint ]:    trayIconCenter: QPoint(1156,370)
>2020-08-25 13:48:39:564 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowPosition ]:    taskbarScreenEdge: OCC::Systray::TaskBarPosition::Top
>2020-08-25 13:48:39:564 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowPosition ]:    screenRect: QRect(0,0 1920x1080)
>2020-08-25 13:48:39:564 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowPosition ]:    windowRect (reference) QRect(956,36 401x511)
>2020-08-25 13:48:39:564 [ debug nextcloud.gui.systray ]    [ OCC::Systray::computeWindowPosition ]:    windowRect (adjusted ) QRect(956,36 401x511)
>```
>
>Maybe of note is that Arch still have Nextcloud Client 3.0.0 in Testing -- there may be a reason they've kept it there for a while now (perhaps this issue isn't because of your patches).
>
>25 Aug 2020, 12:01 by
>
>> Hi
>>
>> here is a patch to upgrade nextcloud-client to current version 3.0.0.
>>
>> Successfully tested on x86_64, built for i686. The build for arm
>> failed...
>>
>>
>> Parabola Website Notification <nobody at parabola.nu> schrieb am Fri, 21. Aug 20 10:05:
>>
>>> eomc20a2q99n at opayq.com wants to notify you that the following packages may be out-of-date:
>>>
>>>
>>> * nextcloud-client 2.6.4-1.parabola1 [libre] (i686): https://parabolagnulinux.org/packages/libre/i686/nextcloud-client/
>>> * nextcloud-client 2.6.4-1.parabola1 [libre] (x86_64): https://parabolagnulinux.org/packages/libre/x86_64/nextcloud-client/
>>>
>>>
>>> The user provided the following additional text:
>>>
>>> 3.0.0 is out:
>>>
>>> https://github.com/nextcloud/desktop/releases/tag/v3.0.0
>>>
>>> _______________________________________________
>>> Dev mailing list
>>> Dev at lists.parabola.nu
>>> https://lists.parabola.nu/mailman/listinfo/dev
>>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.parabola.nu/pipermail/dev/attachments/20200825/03d9fdfd/attachment.sig>