[Dev] [PATCH] libremakepkg: fix building packages requring a rw startdir

[Megver83]

El 19-05-19 a las 04:33, bill-auger escribió:
> the log message for the commit that introduced this change indicates that it was necessary for some reason - i think it would be hasty to revert this until we know what the trade-off would be
> 
>   "- We mount the temporary directory containing the extracted source package files read-only, to be sure that makepkg doesn't modify the PKGBUILD. This is necessary because --holdver only disables pkgver() if it's a VCS package."
> 
> right now, i think the only packages that are broken by this are the kernels - there is a single command that requires a writable /startdir, and it does not appear to have any value whatsoever - all that it does is write the 'pkgbase' into the .install script - 'pkgbase' will never change, so that could and should be hard-coded into the .install script - i suggest this change to the kernels PKGBUILDs instead
> 

Well, (as I said in IRC and the bug tracker) I'm not having this issue
with the [nonsystemd] libretools. I'll reverts these changes hence in
some moment

> 
> --- a/linux.install
> +++ b/linux.install
> @@ -7,8 +7,6 @@
>  }
>  
>  post_remove() {
> -  rm -f boot/initramfs-%PKGBASE%.img
> -  rm -f boot/initramfs-%PKGBASE%-fallback.img
> +  rm -f boot/initramfs-linux-libre.img
> +  rm -f boot/initramfs-linux-libre-fallback.img
>  }
> -
> -# vim:set ft=sh ts=8 sts=2 sw=2 et:
> 
> 
> --- a/PKGBUILD
> +++ b/PKGBUILD
> @@ -10,7 +10,7 @@
>  # Based on linux package
>  
>  pkgbase=linux-libre         # Build stock kernel
> -#pkgbase=linux-libre-custom # Build kernel with a different name
> +#pkgbase=linux-libre-custom # Build kernel with a different name (ASSERT: hard-coded into linux.install)
>  _srcbasever=5.1-gnu
>  _srcver=5.1.3-gnu
>  
> @@ -225,10 +225,6 @@
>    "
>    fi
>  
> -  # hack to allow specifying an initially nonexisting install file
> -  sed "$subst" "$startdir/$install" > "$startdir/$install.pkg"
> -  true && install=$install.pkg
> -
>    # fill in mkinitcpio preset and pacman hooks
>    sed "$subst" ../linux.preset | install -Dm644 /dev/stdin \
>      "$pkgdir/etc/mkinitcpio.d/$pkgbase.preset"
> _______________________________________________
> Dev mailing list
> Dev at lists.parabola.nu
> https://lists.parabola.nu/mailman/listinfo/dev
> 

-- 
~Megver83

SIP: megver83 at sip.linphone.org
XMPP: megver83 at jabjab.de
Tox: megver83 at toxme.io
GPG: 0x227CA7C556B2BA78
GNUSocial: @megver82 at quitter.cl
Diaspora*: megver83 at diasp.org
Matrix: @Megver83:matrix.org
PixelFed: pixelfed.social/Megver83
PeerTube: peertube.xtenz.xyz/accounts/megver83

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 520 bytes
Desc: OpenPGP digital signature
URL: <https://lists.parabola.nu/pipermail/dev/attachments/20190520/046f48b7/attachment.sig>