[Dev] dbscripts 20180502 / winston.parabola.nu upgrade

[Luke Shumaker]

On Wed, 02 May 2018 13:50:38 -0400,
Luke Shumaker wrote:
> 
> On Wed, 02 May 2018 12:00:04 -0400,
> Luke Shumaker wrote:
> >  - db-import-pkg:
> >    * Preserve file permissions when copying .db files in to place
> ...
> > The big item here is that this completes the umask change introduced
> > in 20180429, in preparation for adjusting the user permissions on the
> > repos (step 3 of my plan for improving dbscripts).
> > 
> >   [X] 1. Split archlinux -> {packages,community}
> >   [X] 2. Add config.local.* files
> >   [-] 3. Set up the `repo` group        [eta: 2018-05-04]
> >   [ ] 4. Set DBSCRIPTS_CONFIG           [eta: 2018-05-04]
> >   [X] 5. Use systemd timers
> >   [ ] 6. Use db-update                  [eta: 2018-05-05]
> >   [ ] 7. Migrate humans off of repo@    [eta: no sooner than 2018-05-11]
> >   [ ] 8. Migrate robots off of repo@    [eta: no sooner than 2018-05-18]
> > 
> > The fact that the umask changed introduced in 20180429 didn't "stick"
> > means that I need to wait a bit longer before performing step 3,
> > delaying the entire schedule a bit.
> 
> So, it still didn't take.
> 
> I think maybe #6 will get bumped ahead of #3?
> I had thought that #3 would be very simple.

I said I'd forget about it for a while and move on to #6, but I'm
apparently bad at forgetting about things I say I will.

So I ended up tearing my hair out figuring out what was going on.  It
turned out that repo-add sets `umask 022`, disregarding what we
do... so how does db-functions work!?  Somehow, in my
thickheaded-ness, I missed db-functions:set_repo_permissions().

So I'm not entirely sure what the point of setting `umask 002` is,
since I'm pretty sure that the .db files are the only files modified
in a place where it would affect anything.

So... I guess this means that I either need to load db-functions in
db-import-pkg (to call set_repo_permissions), or I can wait for step
#6 and get it for free.

-- 
Happy hacking,
~ Luke Shumaker