[Dev] [PATCH] libretools: fix i686 gpg signature failures
Luke Shumaker
lukeshu at lukeshu.com
Wed Mar 21 23:04:58 GMT 2018
On Wed, 21 Mar 2018 18:18:07 -0400,
Josh Branning wrote:
> Ignore the last two emails.
>
> Code seems to work as expected.
>
> I see you are purposefully testing for a negative and not that the
> line is wrong.
>
> if setarch $setarch /bin/false 2>/dev/null; then
>
> Would have been more readable instead of a double negative; bit confusing.
That would never trigger, there is no way that exits with 0. If
setarch fails, it exits with 1. If setarch succeeds, then it runs
/bin/false, which exits with 1. No matter what, it exits with 1.
--
Happy hacking,
~ Luke Shumaker
More information about the Dev
mailing list