[Dev] [PATCH] libretools: fix i686 gpg signature failures
Luke Shumaker
lukeshu at lukeshu.com
Wed Mar 21 01:16:52 GMT 2018
On Tue, 20 Mar 2018 16:51:49 -0400,
Andreas Grapentin wrote:
> archlinux32 is building their own arch=(any) packages, which means they
> can't share the same cachedir as the x86_64 built -any packages. This
> patch adds a separate cachedir for each CARCH in librechroot, which
> should solve the signature issues we have seen in libremakepkg.
But we don't import arch=(any) packages from archlinux32 anymore, do
we?
Actually, I don't think we import arch=(any) packages from ALARM
anymore either. Does that mean we can get rid of this hack?
CC'ing isacdaavid because he's more knowledgeable about db-import-pkg
than I am.
>
> -A
>
> ---
It's not a big deal, but please put signatures & meta-commentary below
the "---". The stuff above "---" should be the desired commit
message.
> src/chroot-tools/librechroot | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/chroot-tools/librechroot b/src/chroot-tools/librechroot
> index 8256d77..4360622 100755
> --- a/src/chroot-tools/librechroot
> +++ b/src/chroot-tools/librechroot
> @@ -94,10 +94,12 @@ hack_arch_nspawn_flags() {
>
> # Let qemu/binfmt_misc do its thing
> arch_nspawn_flags+=(-f "$interpreter" -s)
> + fi
>
> - # The -any packages are built separately for ARM from
> - # x86, so if we use the same CacheDir as the x86 host,
> - # then there will be PGP errors.
> + if [[ $CARCH != $(uname -m) ]]; then
> + # The -any packages are built seperately for all arches,
> + # so if we use the same CacheDir as the host, then there
> + # will be PGP errors.
> mkdir -p "/var/cache/pacman/pkg-$CARCH"
> arch_nspawn_flags+=(-c "/var/cache/pacman/pkg-$CARCH")
> fi
> --
> 2.16.2
If I'm mistaken, and we do import arch=(any) packages from
archlinux32, then this LGTM.
--
Happy hacking,
~ Luke Shumaker
More information about the Dev
mailing list