[Dev] [dbscripts] [PATCH 1/6] db-update: Check that packages with invalid signatures wont get added

Luke Shumaker lukeshu at lukeshu.com
Tue Apr 3 20:10:54 GMT 2018


From: Pierre Schmitz <pierre at archlinux.de>

(cherry picked from commit 41f4b54c56702610e23ba9130b2022c3f0fe5961)
---
 test/cases/signed-packages.bats | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/test/cases/signed-packages.bats b/test/cases/signed-packages.bats
index 60aec2f..9fb1626 100755
--- a/test/cases/signed-packages.bats
+++ b/test/cases/signed-packages.bats
@@ -5,13 +5,15 @@ load ../lib/common
 	db-update
 }
 
- at test "add unsigned package" {
+ at test "add unsigned package fails" {
 	releasePackage extra 'pkg-simple-a' 'i686'
 	rm "${STAGING}"/extra/*.sig
 	! db-update >/dev/null 2>&1
+
+	checkRemovedPackage extra pkg-simple-a-1-1-i686.pkg.tar.xz i686
 }
 
- at test "add invalid signed package" {
+ at test "add invalid signed package fails" {
 	local p
 	releasePackage extra 'pkg-simple-a' 'i686'
 	for p in "${STAGING}"/extra/*${PKGEXT}; do
@@ -19,13 +21,17 @@ load ../lib/common
 		xz -0 "${p%%.xz}"
 	done
 	! db-update >/dev/null 2>&1
+
+	checkRemovedPackage extra pkg-simple-a-1-1-i686.pkg.tar.xz i686
 }
 
- at test "add broken signature" {
+ at test "add broken signature fails" {
 	local s
 	releasePackage extra 'pkg-simple-a' 'i686'
 	for s in "${STAGING}"/extra/*.sig; do
 		echo 0 > "$s"
 	done
 	! db-update >/dev/null 2>&1
+
+	checkRemovedPackage extra pkg-simple-a-1-1-i686.pkg.tar.xz i686
 }
-- 
2.16.2




More information about the Dev mailing list